Skip to content

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Oct 7, 2025

Rationale for this change

Old image fails due to debian update

What changes are included in this PR?

Use newer image

Are these changes tested?

Will submit crossbow run

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 7, 2025
@thisisnic
Copy link
Member Author

thisisnic commented Oct 7, 2025

@github-actions crossbow submit test-r-rhub-ubuntu-gcc12-custom-ccache

Copy link

github-actions bot commented Oct 7, 2025

Revision: e8f13ee

Submitted crossbow builds: ursacomputing/crossbow @ actions-197d82a697

Task Status
test-r-rhub-ubuntu-gcc12-custom-ccache Azure

@thisisnic thisisnic marked this pull request as ready for review October 7, 2025 11:55
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me. I am unsure if there was any requirement as per running with debian-gcc instead of ubuntu but if there isn't a requirement, happy to merge

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 7, 2025
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thisisnic thisisnic merged commit a273e28 into apache:main Oct 7, 2025
9 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Oct 7, 2025
Copy link

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit a273e28.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

raulcd pushed a commit that referenced this pull request Oct 8, 2025
…rted image (#47730)

### Rationale for this change

Old image fails due to debian update

### What changes are included in this PR?

Use newer image

### Are these changes tested?

Will submit crossbow run

### Are there any user-facing changes?

No
* GitHub Issue: #47705

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants